You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2023/04/03 05:12:35 UTC

[GitHub] [calcite-avatica] stoty commented on pull request #217: CALCITE-5581: Client side LB implementation

stoty commented on PR #217:
URL: https://github.com/apache/calcite-avatica/pull/217#issuecomment-1493674848

   Functionally,this looks good.
   Some remaining issues:
   
   - As Julien mentioned, URLs including commas are problematic. I think that specifying the encoded comma %2C in the URLs should work. Can you test and conform this ?
   - Need to add the new features to the docs
   - Need a release note that summarizes the feature (in this JIRA)
   - Invite another round of reviews by replying to your original email on the dev list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org