[GitHub] [arrow-rs] askoa commented on pull request #3662: feat: IPC support for run encoded array.

["askoa (via GitHub)" <gi...@apache.org>]

askoa commented on PR #3662:
URL: https://github.com/apache/arrow-rs/pull/3662#issuecomment-1420702970

   I am changing this to draft because I just realized that the IPC writer, written in this PR, for run encoded array does not support `offset > 0` or `length < original length` in `ArrayData`. 
   
   Supporting `offset > 0` or `length < original length` **is not a trivial task**. The way `ArrayData` is `sliced` for `RunArray` will have implications across all the functions that use `ArrayData`.  For e.g. the recently merged take kernel (#3622) does not work when `offset > 0`. 
   
   My proposal for this PR: The IPC writer will panic if the `offset > 0` or `length < original length` in the input `ArrayData`. Gradually add support for sliced `ArrayData` in subsequent PRs. Let me know what you think.
   
   cc: @tustvold @viirya 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org