You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2010/11/15 21:22:15 UTC
[jira] Created: (CASSANDRA-1749) Streaming should hold a reference
to the source SSTR to prevent GC races
Streaming should hold a reference to the source SSTR to prevent GC races
------------------------------------------------------------------------
Key: CASSANDRA-1749
URL: https://issues.apache.org/jira/browse/CASSANDRA-1749
Project: Cassandra
Issue Type: Bug
Reporter: Stu Hood
Priority: Critical
Fix For: 0.7.0
An SSTable waiting to be streamed will be GC'd and deleted from disk if there are no references being held to its SSTableReader. While streaming an SSTable, we should hold an SSTR reference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1749) Streaming should hold a reference
to the source SSTR to prevent GC races
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1749:
--------------------------------
Attachment: 0001-Add-SSTable-reference-to-PendingFile-to-prevent-GC-of-.txt
> Streaming should hold a reference to the source SSTR to prevent GC races
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-1749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1749
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Priority: Critical
> Fix For: 0.7.0
>
> Attachments: 0001-Add-SSTable-reference-to-PendingFile-to-prevent-GC-of-.txt
>
>
> An SSTable waiting to be streamed will be GC'd and deleted from disk if there are no references being held to its SSTableReader. While streaming an SSTable, we should hold an SSTR reference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1749) Streaming should hold a
reference to the source SSTR to prevent GC races
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932218#action_12932218 ]
Jonathan Ellis commented on CASSANDRA-1749:
-------------------------------------------
doesn't passing sstable make the descriptor param redundant?
> Streaming should hold a reference to the source SSTR to prevent GC races
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-1749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1749
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Critical
> Fix For: 0.7.0
>
> Attachments: 0001-Add-SSTable-reference-to-PendingFile-to-prevent-GC-of-.txt
>
>
> An SSTable waiting to be streamed will be GC'd and deleted from disk if there are no references being held to its SSTableReader. While streaming an SSTable, we should hold an SSTR reference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1749) Streaming should hold a
reference to the source SSTR to prevent GC races
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932229#action_12932229 ]
Stu Hood commented on CASSANDRA-1749:
-------------------------------------
> doesn't passing sstable make the descriptor param redundant?
There is another constructor that passes only the descriptor.
> Streaming should hold a reference to the source SSTR to prevent GC races
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-1749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1749
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Critical
> Fix For: 0.7.0
>
> Attachments: 0001-Add-SSTable-reference-to-PendingFile-to-prevent-GC-of-.txt
>
>
> An SSTable waiting to be streamed will be GC'd and deleted from disk if there are no references being held to its SSTableReader. While streaming an SSTable, we should hold an SSTR reference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1749) Streaming should hold a
reference to the source SSTR to prevent GC races
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933304#action_12933304 ]
Hudson commented on CASSANDRA-1749:
-----------------------------------
Integrated in Cassandra-0.7 #14 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/14/])
retain reference to PendingFile sstables
patch by Stu Hood; reviewed by jbellis for CASSANDRA-1749
> Streaming should hold a reference to the source SSTR to prevent GC races
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-1749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1749
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Critical
> Fix For: 0.7.0
>
> Attachments: 0001-Add-SSTable-reference-to-PendingFile-to-prevent-GC-of-.txt
>
>
> An SSTable waiting to be streamed will be GC'd and deleted from disk if there are no references being held to its SSTableReader. While streaming an SSTable, we should hold an SSTR reference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.