You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by steveloughran <gi...@git.apache.org> on 2015/09/14 17:41:58 UTC
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
GitHub user steveloughran opened a pull request:
https://github.com/apache/spark/pull/8748
Stevel/patches/spark 8789 sql query suite table drop
Updated version of SPARK-8789 which switches to `withSqlContext` for the operations which change the sql context.
Note that `withTable()` doesn't clean up tables before a test run: if there is a spurious table before the operation, then a test may fail. Ideally it should be doing cleanup in advance too; I didn't address that code as it would impact more test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveloughran/spark stevel/patches/SPARK-8789-SQLQuerySuite-table-drop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8748.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8748
----
commit 81c56d0f1f43bbbe1b721e71f697a54bf0c95cd3
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-07-02T12:15:47Z
SPARK-8789 improve SQLQuerySuite resilience by dropping tables in setup
commit a3ea48c1c4fea277dad3846cb41801e6acbed1d9
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-07-02T18:06:25Z
SPARK-8789 SQLQuerySuite to use withTable. This is a copy of the SQLTestUtils one -that expected a sqlContext, whereas in this test it all appears to be implicit
commit 5d8970ed3c62ce94d101a9c7e49d295283c3dd01
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-09-14T14:50:57Z
SPARK-8789 sql table cleanup sync up with/review master
commit 409325598eb15abde1ce46fb55d610c295a507c9
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-09-14T15:18:38Z
SPARK-8789 using withSqlContext
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-140157776
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-140122195
[Test build #42427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42427/consoleFull) for PR 8748 at commit [`4093255`](https://github.com/apache/spark/commit/409325598eb15abde1ce46fb55d610c295a507c9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-140157778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42427/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-140119900
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-140157619
[Test build #42427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42427/console) for PR 8748 at commit [`4093255`](https://github.com/apache/spark/commit/409325598eb15abde1ce46fb55d610c295a507c9).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-148837394
Hey @steveloughran, would you mind bringing this up to date and fixing the conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by steveloughran <gi...@git.apache.org>.
Github user steveloughran closed the pull request at:
https://github.com/apache/spark/pull/8748
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by steveloughran <gi...@git.apache.org>.
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-149222286
will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-140119939
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Stevel/patches/spark 8789 sql query suite tabl...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8748#issuecomment-155560306
@steveloughran have you had a chance to update this? If not can you close this patch for now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org