You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/30 10:44:41 UTC

[GitHub] [airflow] kaxil commented on issue #5958: [AIRFLOW-5335] Simplify GCSHook test

kaxil commented on issue #5958: [AIRFLOW-5335] Simplify GCSHook test
URL: https://github.com/apache/airflow/pull/5958#issuecomment-526555445
 
 
   I like the idea. Only 1 issue regarding client_info, it creates a separate object:
   
   ```
   AssertionError: Expected call: Client(client_info=<google.api_core.gapic_v1.client_info.ClientInfo object at 0x110f774a8>, credentials='CREDENTIALS', project='PROJECT_ID')
   Actual call: Client(client_info=<google.api_core.gapic_v1.client_info.ClientInfo object at 0x11f47a080>, credentials='CREDENTIALS', project='PROJECT_ID')
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services