You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/11/27 08:04:17 UTC
[GitHub] jsj020122 commented on a change in pull request #15: move define to
common.h
jsj020122 commented on a change in pull request #15: move define to common.h
URL: https://github.com/apache/rocketmq-client-cpp/pull/15#discussion_r236553451
##########
File path: include/RocketMQClient.h
##########
@@ -16,24 +16,7 @@
*/
#ifndef __ROCKETMQCLIENT_H__
#define __ROCKETMQCLIENT_H__
-
-#ifdef WIN32
-#ifdef ROCKETMQCLIENT_EXPORTS
-#ifdef _WINDLL
-#define ROCKETMQCLIENT_API __declspec(dllexport)
-#else
-#define ROCKETMQCLIENT_API
-#endif
-#else
-#ifdef ROCKETMQCLIENT_IMPORT
-#define ROCKETMQCLIENT_API __declspec(dllimport)
-#else
-#define ROCKETMQCLIENT_API
-#endif
-#endif
-#else
-#define ROCKETMQCLIENT_API
-#endif
+#include "CCommon.h"
Review comment:
the cpp also need exports class and function
1.CPP interface will depend on C interface .
2. C interface independent the CPP interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services