You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Tim-Christian Mundt (JIRA)" <se...@james.apache.org> on 2010/08/21 23:13:16 UTC

[jira] Updated: (IMAP-206) Straighten Non-/TransactionalMapper Hierarchy

     [ https://issues.apache.org/jira/browse/IMAP-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim-Christian Mundt updated IMAP-206:
-------------------------------------

    Attachment: TransactionalMappers.patch

The changes are really not too complicated. Just some refactoring. The patch is created against revision 987444.

> Straighten Non-/TransactionalMapper Hierarchy
> ---------------------------------------------
>
>                 Key: IMAP-206
>                 URL: https://issues.apache.org/jira/browse/IMAP-206
>             Project: JAMES Imap
>          Issue Type: Improvement
>            Reporter: Tim-Christian Mundt
>            Priority: Minor
>         Attachments: TransactionalMappers.patch
>
>
> There are two things I find odd about the Mapper hierarchy:
> a) NonTransactionalMapper extends TransactionalMapper which is semantically confusing.
> b) The Store API refers to TransactionalMappers where any Mapper (transactional or not) is appropriate. Moreover, the Mappers inherit from TransactionalMapper two times: once via AbstractTransactionalMapper and once via Message/Mailbox/SubscriptionMapper.
> I'd like to have it more straight forward:
> 1) Have a base Mapper, which gets implemented by a TransactionalMapper and a NonTransactionalMapper (both abstract).
> 2) The Message/Mailbox/SubscriptionMapper interfaces should not care about transactions and thus not inherit at all.
> 3) The implementations extend one of Transactional- or NonTransactionalMapper and implement one of Message/Mailbox/SubscriptionMapper.
> This way the hierarchy is clearer and function (message...) and transaction are separated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org