You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by wang yaoxin <wa...@cmss.chinamobile.com> on 2017/03/06 06:29:07 UTC
Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57326/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle.
Bugs: AMBARI-18892
https://issues.apache.org/jira/browse/AMBARI-18892
Repository: ambari
Description
-------
when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate
Diffs
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml 4cfe3d5
ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d
ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db
ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b
Diff: https://reviews.apache.org/r/57326/diff/1/
Testing
-------
done?
File Attachments
----------------
storm.png
https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png
Thanks,
wang yaoxin
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57326/#review167999
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
Lines 101 (patched)
<https://reviews.apache.org/r/57326/#comment240009>
Set <on-ambari-upgrade add="false"/> unless they need to be added to earlier stacks.
- Alejandro Fernandez
On March 6, 2017, 6:29 a.m., wang yaoxin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57326/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 6:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle.
>
>
> Bugs: AMBARI-18892
> https://issues.apache.org/jira/browse/AMBARI-18892
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml 4cfe3d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d
> ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b
>
>
> Diff: https://reviews.apache.org/r/57326/diff/1/
>
>
> Testing
> -------
>
> done?
>
>
> File Attachments
> ----------------
>
> storm.png
> https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png
>
>
> Thanks,
>
> wang yaoxin
>
>
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
Posted by wang yaoxin <wa...@cmss.chinamobile.com>.
> On \u4e09\u6708 6, 2017, 4:47 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
> > Lines 99-109 (patched)
> > <https://reviews.apache.org/r/57326/diff/1/?file=1656518#file1656518line99>
> >
> > Are these _new_ properties used anywhere?
These new properties are not used .
- wang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57326/#review167997
-----------------------------------------------------------
On \u4e09\u6708 7, 2017, 2:59 a.m., wang yaoxin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57326/
> -----------------------------------------------------------
>
> (Updated \u4e09\u6708 7, 2017, 2:59 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle.
>
>
> Bugs: AMBARI-18892
> https://issues.apache.org/jira/browse/AMBARI-18892
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d
> ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b
>
>
> Diff: https://reviews.apache.org/r/57326/diff/2/
>
>
> Testing
> -------
>
> done?
>
>
> File Attachments
> ----------------
>
> storm.png
> https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png
>
>
> Thanks,
>
> wang yaoxin
>
>
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
Posted by wang yaoxin <wa...@cmss.chinamobile.com>.
> On \u4e09\u6708 6, 2017, 4:47 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
> > Lines 99-109 (patched)
> > <https://reviews.apache.org/r/57326/diff/1/?file=1656518#file1656518line99>
> >
> > Are these _new_ properties used anywhere?
>
> wang yaoxin wrote:
> These new properties are not used .
These new properties are not being used elsewhere
- wang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57326/#review167997
-----------------------------------------------------------
On \u4e09\u6708 7, 2017, 2:59 a.m., wang yaoxin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57326/
> -----------------------------------------------------------
>
> (Updated \u4e09\u6708 7, 2017, 2:59 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle.
>
>
> Bugs: AMBARI-18892
> https://issues.apache.org/jira/browse/AMBARI-18892
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d
> ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b
>
>
> Diff: https://reviews.apache.org/r/57326/diff/2/
>
>
> Testing
> -------
>
> done?
>
>
> File Attachments
> ----------------
>
> storm.png
> https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png
>
>
> Thanks,
>
> wang yaoxin
>
>
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57326/#review167997
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
Lines 99-109 (patched)
<https://reviews.apache.org/r/57326/#comment240007>
Are these _new_ properties used anywhere?
ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json
Lines 92-113 (original), 92-113 (patched)
<https://reviews.apache.org/r/57326/#comment240006>
This Kerberos identity descriptor should really be a reference to the duplicated on in the `NIMBUS` component descriptor. This can be done by setting a `reference` attrute like this:
```
{
"name": "drpc_server",
"reference": "/STORM/NIMBUS/nimbus_server"
}
```
Since I do not see any usage of `storm-env/numbus_drpc_keytab`, this change is potentially causing data loss.
ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json
Lines 122-141 (original), 122-141 (patched)
<https://reviews.apache.org/r/57326/#comment240008>
Same as above, related to the _reference_.
- Robert Levas
On March 6, 2017, 1:29 a.m., wang yaoxin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57326/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 1:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle.
>
>
> Bugs: AMBARI-18892
> https://issues.apache.org/jira/browse/AMBARI-18892
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml 4cfe3d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d
> ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b
>
>
> Diff: https://reviews.apache.org/r/57326/diff/1/
>
>
> Testing
> -------
>
> done?
>
>
> File Attachments
> ----------------
>
> storm.png
> https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png
>
>
> Thanks,
>
> wang yaoxin
>
>
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57326/#review168112
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On March 6, 2017, 9:59 p.m., wang yaoxin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57326/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 9:59 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle.
>
>
> Bugs: AMBARI-18892
> https://issues.apache.org/jira/browse/AMBARI-18892
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d
> ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b
>
>
> Diff: https://reviews.apache.org/r/57326/diff/2/
>
>
> Testing
> -------
>
> done?
>
>
> File Attachments
> ----------------
>
> storm.png
> https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png
>
>
> Thanks,
>
> wang yaoxin
>
>
Re: Review Request 57326: storm DRPC_SERVER kerberos configs duplicate
Posted by wang yaoxin <wa...@cmss.chinamobile.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57326/
-----------------------------------------------------------
(Updated \u4e09\u6708 7, 2017, 2:59 a.m.)
Review request for Ambari, Alejandro Fernandez, Robert Levas, and Sid Wagle.
Bugs: AMBARI-18892
https://issues.apache.org/jira/browse/AMBARI-18892
Repository: ambari
Description
-------
when ambari enables kerberos, storm service ,nimbus_keytab and nimbus_principal_name will duplicate
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 20cc32d
ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json fa2f6db
ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 0a8f20b
Diff: https://reviews.apache.org/r/57326/diff/2/
Changes: https://reviews.apache.org/r/57326/diff/1-2/
Testing
-------
done?
File Attachments
----------------
storm.png
https://reviews.apache.org/media/uploaded/files/2017/03/06/35c14040-f918-4f46-83e8-be51a01d5d53__storm.png
Thanks,
wang yaoxin