[GitHub] mistercrunch edited a comment on issue #5532: Dashboard position_json truncates if dashboard gets too large

[GitBox <gi...@apache.org>]

mistercrunch edited a comment on issue #5532: Dashboard position_json truncates if dashboard gets too large
URL: https://github.com/apache/incubator-superset/issues/5532#issuecomment-409818628
 
 
   In mysql, `MEDIUMTEXT` allows for 16mb:
   ```
         Type | Maximum length
   -----------+-------------------------------------
     TINYTEXT |           255 (2 8−1) bytes
         TEXT |        65,535 (216−1) bytes = 64 KiB
   MEDIUMTEXT |    16,777,215 (224−1) bytes = 16 MiB
     LONGTEXT | 4,294,967,295 (232−1) bytes =  4 GiB
   ```
   https://stackoverflow.com/questions/13932750/tinytext-text-mediumtext-and-longtext-maximum-storage-sizes
   
   Though while you could just go ALTER TABLE and call it a day in your env, we should find a way for SQLAlchemy to work regardless of the engine used. Maybe some conditions around which engine is used in a db migration script, and point to `sqlalchemy.dialects.mysql.MEDIUMTEXT` where mysql is used. 
   
   http://docs.sqlalchemy.org/en/latest/dialects/mysql.html#sqlalchemy.dialects.mysql.MEDIUMTEXT

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org