You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/07/16 00:52:56 UTC
Review Request 23528: Upgrade to public release of pants
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23528/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Kevin Sweeney.
Repository: aurora
Description
-------
Point pants at the public release instead of github fork. This may require a git clean -fdx to clear out the identically pants 0.0.17 pex.
Upgrades pex to 0.5.9 while we're at it.
Diffs
-----
build-support/pex f96c02a3945631239db308aceae75f71a70ce087
pants 36c6afa17b72d375a5cc4a3d5d6f499fff04d962
Diff: https://reviews.apache.org/r/23528/diff/
Testing
-------
./pants src/test/python/apache/aurora:all -v
Thanks,
Brian Wickman
Re: Review Request 23528: Upgrade to public release of pants
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23528/#review47840
-----------------------------------------------------------
Ship it!
awesome
- Joe Smith
On July 15, 2014, 4:37 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23528/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 4:37 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-583
> https://issues.apache.org/jira/browse/AURORA-583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Point pants at the public release instead of github fork. This may require a git clean -fdx to clear out the identically pants 0.0.17 pex.
> Upgrades pex to 0.5.9 while we're at it.
>
>
> Diffs
> -----
>
> build-support/pex f96c02a3945631239db308aceae75f71a70ce087
> pants 36c6afa17b72d375a5cc4a3d5d6f499fff04d962
>
> Diff: https://reviews.apache.org/r/23528/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora:all -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23528: Upgrade to public release of pants
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23528/#review47839
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On July 15, 2014, 4:37 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23528/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 4:37 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-583
> https://issues.apache.org/jira/browse/AURORA-583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Point pants at the public release instead of github fork. This may require a git clean -fdx to clear out the identically pants 0.0.17 pex.
> Upgrades pex to 0.5.9 while we're at it.
>
>
> Diffs
> -----
>
> build-support/pex f96c02a3945631239db308aceae75f71a70ce087
> pants 36c6afa17b72d375a5cc4a3d5d6f499fff04d962
>
> Diff: https://reviews.apache.org/r/23528/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora:all -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23528: Upgrade to public release of pants
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23528/
-----------------------------------------------------------
(Updated July 15, 2014, 11:37 p.m.)
Review request for Aurora, Joe Smith and Kevin Sweeney.
Changes
-------
Address kevin's feedback
Bugs: AURORA-583
https://issues.apache.org/jira/browse/AURORA-583
Repository: aurora
Description
-------
Point pants at the public release instead of github fork. This may require a git clean -fdx to clear out the identically pants 0.0.17 pex.
Upgrades pex to 0.5.9 while we're at it.
Diffs (updated)
-----
build-support/pex f96c02a3945631239db308aceae75f71a70ce087
pants 36c6afa17b72d375a5cc4a3d5d6f499fff04d962
Diff: https://reviews.apache.org/r/23528/diff/
Testing
-------
./pants src/test/python/apache/aurora:all -v
Thanks,
Brian Wickman
Re: Review Request 23528: Upgrade to public release of pants
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23528/#review47834
-----------------------------------------------------------
pants
<https://reviews.apache.org/r/23528/#comment84063>
Since cache-invalidation is a yet-unsolved hard problem (and in fact the cause of this bug), how do you feel about changing the name of the generated .pex to something like pantsbuild.pants-$PANTS_VERSION.pex. That way it'll work without a git clean -fdx.
- Kevin Sweeney
On July 15, 2014, 3:53 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23528/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 3:53 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-583
> https://issues.apache.org/jira/browse/AURORA-583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Point pants at the public release instead of github fork. This may require a git clean -fdx to clear out the identically pants 0.0.17 pex.
> Upgrades pex to 0.5.9 while we're at it.
>
>
> Diffs
> -----
>
> build-support/pex f96c02a3945631239db308aceae75f71a70ce087
> pants 36c6afa17b72d375a5cc4a3d5d6f499fff04d962
>
> Diff: https://reviews.apache.org/r/23528/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora:all -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23528: Upgrade to public release of pants
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23528/
-----------------------------------------------------------
(Updated July 15, 2014, 10:53 p.m.)
Review request for Aurora, Joe Smith and Kevin Sweeney.
Bugs: AURORA-583
https://issues.apache.org/jira/browse/AURORA-583
Repository: aurora
Description
-------
Point pants at the public release instead of github fork. This may require a git clean -fdx to clear out the identically pants 0.0.17 pex.
Upgrades pex to 0.5.9 while we're at it.
Diffs
-----
build-support/pex f96c02a3945631239db308aceae75f71a70ce087
pants 36c6afa17b72d375a5cc4a3d5d6f499fff04d962
Diff: https://reviews.apache.org/r/23528/diff/
Testing
-------
./pants src/test/python/apache/aurora:all -v
Thanks,
Brian Wickman