You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "olsenbudanur (via GitHub)" <gi...@apache.org> on 2024/12/09 20:56:56 UTC
[PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
olsenbudanur opened a new pull request, #44800:
URL: https://github.com/apache/airflow/pull/44800
<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -->
Implements support for custom CatalogId in AWS GlueCatalogHook methods. This enhancement allows users to specify a custom Data Catalog ID when interacting with AWS Glue services.
*Changes:*
- Added optional catalog_id parameter to get_partitions, get_table, get_partition, and create_partition
- Maintained backward compatibility (CatalogId defaults to None)
- Added comprehensive test coverage for both with/without CatalogId scenarios
*Testing Results:*
- All 905 AWS hooks tests passing (165.27s execution time)
- Added 20 new test cases for CatalogId functionality
- Verified both with/without CatalogId scenarios
- All existing tests remain passing, confirming backward compatibility
- 3 expected skips in hooks_signature tests (unrelated)
Closes: #43238
Link to Devin run: https://preview.devin.ai/devin/f6e5706fdebf47cb8cafcb44e8dd3ccb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "olsenbudanur (via GitHub)" <gi...@apache.org>.
olsenbudanur commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529564089
Asking Devin to look into GlueCatalogPartitionSensor right now! Will verify his results and push it up to this branch. Will send an update once that's done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2617240548
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "olsenbudanur (via GitHub)" <gi...@apache.org>.
olsenbudanur commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529655554
Ack. Asked the Cognition team to reach out through the official channels + the issue thread. Will keep the further updates in the issue to avoid duplicate conversation threads. Ty for the prompt guidance here, interested to see if this goes through :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "olsenbudanur (via GitHub)" <gi...@apache.org>.
olsenbudanur commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529570518
> Only if you (contributor) can fulfill the expectation of the generative tooling policy of the ASF. Otherwise we cannot accept it.
Ack. I am looking into the generative tooling policy + Devin policy as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529559017
> > This is coming from boat account, don't think we accept prs from boat GitHub accounts?
>
> @gopidesupavan I'm using an AI tool, but the PR is not coming from a bot account. I am verifying the results as they get passed. Is that fine?
As explained in the issue, yes you can contribute AI generated code if it follows the policy of the ASF: https://www.apache.org/legal/generative-tooling.html:
> Given the above, code generated in whole or in part using AI can be contributed if the contributor ensures that:
>
> 1. The terms and conditions of the generative AI tool do not place any restrictions on use of the output that would be inconsistent with the [Open Source Definition](https://opensource.org/osd/).
> 2. At least one of the following conditions is met:
> 1. The output is not copyrightable subject matter (and would not be even if produced by a human).
> 2. No third party materials are included in the output.
> 3. Any third party materials that are included in the output are being used with permission (e.g., under a compatible open-source license) of the third party copyright holders and in compliance with the applicable license terms.
> 3. A contributor obtains reasonable certainty that conditions 2.2 or 2.3 are met if the AI tool itself provides sufficient information about output that may be similar to training data, or from code scanning results.
So my quesiton is @olsenbudanur -> can you confirm (and somewhat explain how) those conditions are met ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529508409
This is coming from boat account, don't think we accept prs from boat GitHub accounts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #44800: Add CatalogId support to AWS GlueCatalogHook
URL: https://github.com/apache/airflow/pull/44800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "olsenbudanur (via GitHub)" <gi...@apache.org>.
olsenbudanur commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529518546
> This is coming from boat account, don't think we accept prs from boat GitHub accounts?
@gopidesupavan I'm using a tool, but the PR is not coming from a bot account. I am verifying the results as they get passed. Is that fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "olsenbudanur (via GitHub)" <gi...@apache.org>.
olsenbudanur commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529623060
Okay, added catalog_id to GlueCatalogPartitionSensor! Also, I can confirm that the tool abides by Apache's generative tooling terms:
(copied from the issue thread)
I've contacted the Devin (Cognition) team, and they confirmed that they reviewed the [Apache terms](https://www.apache.org/legal/generative-tooling.html) & [open-source terms](https://opensource.org/osd). They say everything looks fine (can tag someone from their team if needed)
**1- The terms and conditions of the generative AI tool do not place any restrictions on use of the output that would be inconsistent with the [Open Source Definition](https://opensource.org/osd/)**
According to [Devin's terms](https://www.cognition.ai/pages/terms-of-service), all outputs are fully owned by the user. No copyright and no third party materials.
**2- At least one of the following conditions is met**
The output is not copyrightable subject matter. Also no third party materials are used.
**3-**
I am certain that this is not applicable.
@potiuk is there anything I'm missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529430176
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529501527
Can you also add support for catalog in `GlueCatalogPartitionSensor` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529560409
Code looks good, I agree with @eladkal suggestion, it would be awesome if you could do the same kind of changes in `GlueCatalogPartitionSensor `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add CatalogId support to AWS GlueCatalogHook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44800:
URL: https://github.com/apache/airflow/pull/44800#issuecomment-2529647278
As explained in the issue, this is licencing not ownership issue potentially - so you and devin should seek confirmation if this is OK to use such code via https://www.apache.org/legal/#communications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org