You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/09 00:52:03 UTC

[GitHub] [netbeans] mbien opened a new pull request #3575: fixed wrong nb-javac module name so that it can be installed.

mbien opened a new pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575


   when nb-javac is uninstalled by the user and NB is started on a JDK < 17 this dialog will show up:
   ![install-nb-javac](https://user-images.githubusercontent.com/114367/153100286-687b668c-0946-426d-af87-68493bccc39e.png)
   
   However, pressing install did nothing since the module name was wrong (!). This fixes it.
   
   PR is based on delivery branch. I think we should add this even if there won't be another rc.
   
   how to test:
   1) start NB, load java cluster
   2) uninstall nb-javac
   3) start again on JDK 8, dialog should show up
   4) install nb-javac via dalog, restart -> everything should be working again (no dialog)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net merged pull request #3575: fixed wrong nb-javac module name so that it can be installed.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #3575: fixed wrong nb-javac module name so that it can be installed.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575#issuecomment-1040224489


   Thanks @mbien - merging!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #3575: fixed wrong nb-javac module name so that it can be installed.

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575#issuecomment-1033736709


   @neilcsmith-net understood. I do also agree that this is not severe enough to be the cause for another rc - its just a safety net for users which misconfigured NB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net merged pull request #3575: fixed wrong nb-javac module name so that it can be installed.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #3575: fixed wrong nb-javac module name so that it can be installed.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575#issuecomment-1040224489


   Thanks @mbien - merging!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #3575: fixed wrong nb-javac module name so that it can be installed.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575#issuecomment-1037105050


   @mbien we might be looking at another issue that requires an rc4 anyway, in which case this would be good to get in as well. Can we switch it back to delivery / NB13 again for now? :smile:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #3575: fixed wrong nb-javac module name so that it can be installed.

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3575:
URL: https://github.com/apache/netbeans/pull/3575#issuecomment-1033717170


   hi I can go for another RC but we can still start vote next week


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists