You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Nicolas Malin (JIRA)" <ji...@apache.org> on 2019/05/24 08:30:00 UTC
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our
release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847350#comment-16847350 ]
Nicolas Malin commented on OFBIZ-10145:
---------------------------------------
HI [~swapnilmmane] nice return :)
{quote}
So, to fix this, I removed the -b option from whereis command in script.
After this everything works like charm for me.
{quote}
The risk is that you have only documentation or configuration. in this case
{code}
whereIsBinary() {
whereis $1 | grep /
}
{code}
return not empty string
{code}
whereIsBinary() {
whereis -b $1 | grep /
}
{code}
return empty string. But it's a problem if you haven't it under Mac ...
I added your suggest on the script with a delete of corrupt archive before [^init-gradle-wrapper-trunk-and-18.sh]
if it's ok for you we can commit this on trunk, release18 and release17
> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 17.12.01, 16.11.06, 18.12.01
> Reporter: Jacques Le Roux
> Assignee: Nicolas Malin
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, considering LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar file from the next packaged releases and use [~jacopoc]'s related proposition to document how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might change in the future (versions, etc.), so indeed maybe simply asking to download is enough, cf https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)