You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/16 19:00:02 UTC

[jira] [Commented] (AIRFLOW-5682) Add support for labels in gcs_to_bq operator

    [ https://issues.apache.org/jira/browse/AIRFLOW-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953111#comment-16953111 ] 

ASF GitHub Bot commented on AIRFLOW-5682:
-----------------------------------------

lyallcooper commented on pull request #6351: [AIRFLOW-5682] Allow labels in gcs_to_bq operator
URL: https://github.com/apache/airflow/pull/6351
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-5682) issues and references them in the PR title.
   
   ### Description
   
   - [X] Adds support for labels when using the GoogleCloudStorageToBigQuery
   operator.
   
   ### Tests
   
   - [X] My PR adds the following unit test: `test_bigquery.TestLabelsInRunLoad`
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add support for labels in gcs_to_bq operator
> --------------------------------------------
>
>                 Key: AIRFLOW-5682
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5682
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp
>    Affects Versions: 1.10.5
>            Reporter: Lyall Cooper
>            Assignee: Lyall Cooper
>            Priority: Minor
>
> Other BigQuery related operators, such as {{bigquery_to_gcs}} and {{bigquery_to_bigquery}} support BigQuery's "labels" feature, which allows callers to attach arbitrary key-value tags onto the jobs/queries. However, the {{gcs_to_bq}} operator does not currently support this functionality, which would be nice to have.
>  
> Currently a workaround is to use the underlying {{BigQueryHook}} to create a load job from GCS to BQ, but that's not ideal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)