You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/07/19 15:18:56 UTC

[GitHub] brooklyn-server pull request #267: Fix for BROOKLYN-314

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/267

    Fix for BROOKLYN-314

    Try-catch in getOptionalNode/getOptionalImage (e.g. if called by user
    in rebind code, then don\u2019t fail outright if cloud throws exception

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix/BROOKLYN-314

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #267
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #267: Fix for BROOKLYN-314

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/267
  
    @nakomis not particularly easily is the answer, for writing a test to recreate BROOKLYN-314! Would need to stub-out the a JcloudsLocation to simulate the failure, and to write a custom entity and an associated driver that calls `machine.getOsDetails()` in its constructor.
    
    I'll have more of a look at doing that, but am going to merge this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #267: Fix for BROOKLYN-314

Posted by nakomis <gi...@git.apache.org>.

Github user nakomis commented on the issue:

    https://github.com/apache/brooklyn-server/pull/267
  
    Looks good, and pretty straightforward. Could you add a test for the rebind issue described in BROOKLYN-314


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #267: Fix for BROOKLYN-314

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---