You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/17 00:20:48 UTC

[GitHub] [pulsar] dlg99 opened a new pull request, #16100: [Fix][pulsar-io] KCA: handle kafka preCommit() returning earlier offsets than requested

dlg99 opened a new pull request, #16100:
URL: https://github.com/apache/pulsar/pull/16100

   
   The changes are done on top of https://github.com/apache/pulsar/pull/16098 so please ignore first commit until rebased
   
   ### Motivation
   
   preCommit() can return offsets earlier than ones KCA requested to flush.
   Only ack messages up to the committed offsets to avoid skipping data on connector restart.
   
   ### Modifications
   
   code change + test
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   Added unit test
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
   NO
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #16100: [Fix][pulsar-io] KCA: handle kafka preCommit() returning earlier offsets than requested

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #16100:
URL: https://github.com/apache/pulsar/pull/16100#issuecomment-1158584788

   https://github.com/apache/pulsar/pull/16098 has been merged, please rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dlg99 merged pull request #16100: [Fix][pulsar-io] KCA: handle kafka preCommit() returning earlier offsets than requested

Posted by GitBox <gi...@apache.org>.
dlg99 merged PR #16100:
URL: https://github.com/apache/pulsar/pull/16100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org