You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Robert Munteanu (JIRA)" <ji...@apache.org> on 2017/08/30 15:28:00 UTC

[jira] [Commented] (OAK-2710) Utils.unshareString should not generate String instances unless needed

    [ https://issues.apache.org/jira/browse/OAK-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147434#comment-16147434 ] 

Robert Munteanu commented on OAK-2710:
--------------------------------------

[~reschke] - given that we now require Java 8, what do you think of simply removing the Utils#unshareString method?

> Utils.unshareString should not generate String instances unless needed
> ----------------------------------------------------------------------
>
>                 Key: OAK-2710
>                 URL: https://issues.apache.org/jira/browse/OAK-2710
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk
>    Affects Versions: 1.1.7
>            Reporter: Robert Munteanu
>            Priority: Minor
>         Attachments: OAK-2710.patch
>
>
> org.apache.jackrabbit.oak.plugins.document.util.Utils.unshareString creates new String instances unconditionally. Howewer, we can avoid this String creation if the JRE version is recent enough.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)