You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/06 15:08:54 UTC
[GitHub] [superset] geido commented on a change in pull request #14448: chore: Removes less from SliceAdder
geido commented on a change in pull request #14448:
URL: https://github.com/apache/superset/pull/14448#discussion_r627506293
##########
File path: superset-frontend/src/dashboard/components/AddSliceCard.jsx
##########
@@ -41,6 +41,67 @@ const defaultProps = {
lastModified: null,
};
+const Styled = styled.div`
+ .chart-card {
+ border: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ border-radius: ${({ theme }) => theme.gridUnit}px;
Review comment:
Just a nit, but for the sake of brevity since theme is so widely used here you could just - add all the styles within
```
${({ theme})} => `...`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org