You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/05/21 18:01:17 UTC

[GitHub] eolivelli commented on a change in pull request #1417: Issue-1415 org.apache.distributedlog.fs.TestDLFileSystem fails on CI

eolivelli commented on a change in pull request #1417: Issue-1415 org.apache.distributedlog.fs.TestDLFileSystem fails on CI
URL: https://github.com/apache/bookkeeper/pull/1417#discussion_r189666597
 
 

 ##########
 File path: stream/distributedlog/io/dlfs/src/test/java/org/apache/distributedlog/fs/TestDLFileSystem.java
 ##########
 @@ -61,7 +61,7 @@ public void testBasicIO() throws Exception {
         }
         assertTrue(fs.exists(path));
 
-        File tempFile = new File("/tmp/" + runtime.getMethodName());
+        File tempFile = new File(newTempDir(runtime.getMethodName()), "test.bin");
 
 Review comment:
   I tried to use the same style as DL tests, I am not still used to this codebase.
   
   Temporary Folder is better for me. Will change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services