You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/29 08:39:25 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #692: Forward C compiler to build deps in CMake
PragmaTwice opened a new pull request, #692:
URL: https://github.com/apache/incubator-kvrocks/pull/692
In this PR, we make sure that those C dependencies is compiled by the compiler specified by `CMAKE_C_COMPILER`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #692: Forward C compiler to build deps in CMake
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #692:
URL: https://github.com/apache/incubator-kvrocks/pull/692#issuecomment-1170128134
Thanks everyone, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #692: Forward C compiler to build deps in CMake
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #692:
URL: https://github.com/apache/incubator-kvrocks/pull/692#issuecomment-1169738759
> Does this patch fix some issues existing now? BTW as the building logic grow complexity, we may rewrite it with Python or other more structural tools :)
Not yet, but I think it is a potential risk of not specifying the compiler for building dependencies.
Rewriting in python sounds great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #692: Forward C compiler to build deps in CMake
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #692:
URL: https://github.com/apache/incubator-kvrocks/pull/692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #692: Forward C compiler to build deps in CMake
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #692:
URL: https://github.com/apache/incubator-kvrocks/pull/692#issuecomment-1169719929
Does this patch fix some issues existing now? BTW as the building logic grow complexity, we may rewrite it with Python or other more structural tools :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org