[jira] [Commented] (AIRFLOW-4931) Add KMS Encryption Configuration to BigQuery Hook and Operators

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883435#comment-16883435 ] 

ASF GitHub Bot commented on AIRFLOW-4931:
-----------------------------------------

ryanyuan commented on pull request #5567: [AIRFLOW-4931] Add KMS Encryption Configuration to BigQuery Hook and Operators
URL: https://github.com/apache/airflow/pull/5567
 
 
   Add Encryption Configuration, e.g. KMS, to BigQuery Hook and Operators
   
   BigQueryHook:
   - create_empty_table()
   - create_external_table()
   - patch_table()
   - run_query()
   - run_load()
   - run_copy()
   
   BigQueryOperator
   BigQueryCreateEmptyTableOperator
   BigQueryCreateExternalTableOperator
   BigQueryToBigQueryOperator
   GoogleCloudStorageToBigQueryOperator
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow-4931](https://issues.apache.org/jira/browse/AIRFLOW-4931) issues and references them in the PR title. 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   test_bigquery_hook.py:TestBigQueryWithKMS
   test_bigquery_operator.py:BigQueryCreateEmptyTableOperatorTest
   test_bigquery_operator.py:BigQueryOperatorTest
   test_bigquery_operator.py:BigQueryToBigQueryOperatorTest
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add KMS Encryption Configuration to BigQuery Hook and Operators
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-4931
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4931
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp
>    Affects Versions: 1.10.3
>            Reporter: Ryan Yuan
>            Assignee: Ryan Yuan
>            Priority: Critical
>
> One of the clients requires adding KMS encryption on BigQuery tables. 
> Reference:
> [https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#ExternalDataConfiguration]



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)