[PR] Add documentation for creating SPI implementations of `InlineExpressionParser` [shardingsphere]

["linghengqian (via GitHub)" <gi...@apache.org>]

linghengqian opened a new pull request, #33653:
URL: https://github.com/apache/shardingsphere/pull/33653

   Fixes #33635.
   
   Changes proposed in this pull request:
     - Add documentation for creating SPI implementations of `InlineExpressionParser`.
     - Removed suspicious `useUnicode` attribute.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [x] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add documentation for creating SPI implementations of `InlineExpressionParser` [shardingsphere]

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu merged PR #33653:
URL: https://github.com/apache/shardingsphere/pull/33653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add documentation for creating SPI implementations of `InlineExpressionParser` [shardingsphere]

["linghengqian (via GitHub)" <gi...@apache.org>]

linghengqian commented on code in PR #33653:
URL: https://github.com/apache/shardingsphere/pull/33653#discussion_r1841630963


##########
docs/document/content/user-manual/shardingsphere-jdbc/yaml-config/jdbc-driver/known-implementation/_index.en.md:
##########
@@ -213,7 +213,7 @@ Then for the intercepted fragment of the following YAML file,
 ds_1:
   dataSourceClassName: com.zaxxer.hikari.HikariDataSource
   driverClassName: $${FIXTURE_DRIVER_CLASS_NAME::com.mysql.cj.jdbc.Driver}
-  jdbcUrl: jdbc:mysql://$${FIXTURE_HOST::}:$${FIXTURE_PORT::}/$${FIXTURE_DATABASE::}?useUnicode=true&characterEncoding=UTF-8

Review Comment:
   - @malonglei I noticed that this was introduced by #32817. 
   - But https://dev.mysql.com/doc/connector-j/en/connector-j-reference-configuration-properties.html never mentions the existence of a `useUnicode` property. What is the source of this property?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org