[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1184: LUCENE-9142 Refactor IntSet operations for determinize

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #1184: LUCENE-9142 Refactor IntSet operations for determinize
URL: https://github.com/apache/lucene-solr/pull/1184#discussion_r369107817
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/util/automaton/SortedIntSet.java
 ##########
 @@ -149,128 +156,32 @@ public void computeHash() {
         hashCode = 683*hashCode + values[i];
       }
     }
+    stale = false;
   }
 
+  /**
+   * Create a FrozenIntSet from the current values in this IntSet.
+   *
+   * @return a FrozenIntSet that has the same values and hashCode as this set
+   */
+  @SuppressForbidden(reason = "Arrays.copyOf is a candidate for JVM intrinsic and we know our bounds are good")
 
 Review comment:
   Hmm why did we mark this API forbidden again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org