You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/22 12:32:55 UTC

[GitHub] [flink] afedulov opened a new pull request, #20049: [connectors] Mark SourceFunction interface as @Deprecated

afedulov opened a new pull request, #20049:
URL: https://github.com/apache/flink/pull/20049

   This is a trivial change that marks SourceFunction API as @Deprecated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1407709550

   @MartijnVisser unfortunately CI did not capture all failures caused by our strict checks for deprecated APIs in `flink-examples` at once.
    Now that the original sources listed in [FLINK-28227](https://issues.apache.org/jira/browse/FLINK-28227) ([Azure Build 1](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=37208&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=14044)) got fixed, it started failing on two more sources from `flink-examples-table`: [Azure Build 2](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=45333&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=16395).
   Unfortunately, we are missing an integration layer between the new `DataGeneratorSource` and the Table API needed in order to make it work. For instance, `SocketSourceFunction` has to be rewritten as a `GeneratorFunction`, however, we, by design, do not have access to `RuntimeContext` that is required to initialize the serialization schema in the original implementation:
   https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/connectors/SocketSourceFunction.java#L36-L39
   https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/connectors/SocketSourceFunction.java#L72-L74
   This requires a larger effort and won't realistically happen until the release branch cut unless someone who works closely with Table API could take a look.
   Another alternative is to disable the strict policy for using deprecated APIs in `flink-examples-table`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1611244745

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1407470640

   @MartijnVisser https://github.com/apache/flink/pull/21774
   
   @alpinegizmo While reworking the `TopSpeedWindowing` example I found it pretty convoluted.  I believe we previously had discussions about not promoting the usage of the sophisticated trigger-based Window API. Do you maybe have an idea about how to rework it? I personally would not mind dropping it altogether - it does not feel that we promote best practices with it but might rather confuse new users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1600862510

   @MartijnVisser I would like to proceed with the efforts to deprecate the `SourceFunction` interface. The blocker (FLINK-28227) is now resolved: https://github.com/apache/flink/pull/21774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20049: [connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1163044783

   @afedulov The only thing that's missing is starting your commit message with `FLINK-28045`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1166562360

   @flinkbot run azure
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1406489636

   @MartijnVisser Hi Martijn, yes, I'll try to find some time over the weekend to finalize this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1164307368

   RE: Build Failure:
   We will be able to provide proper alternatives for the deprecated versions of the examples when we finalize [FLIP-238](https://cwiki.apache.org/confluence/x/9Av1D). I would prefer not to block marking SourceFunction API deprecated because of them. I think it is OK to use warnings suppression for these four deprecation warnings for now. Here is a new follow-up subtask in the umbrella deprecation ticket to address [FLINK-28227](https://issues.apache.org/jira/browse/FLINK-28227).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1612649076

   @reswqa now that we resolved the blocker in https://github.com/apache/flink/pull/21774 this PR can be merged too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1387594960

   @Myasuka good idea, thanks for bringing it up. I will resume working on it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1170948767

   @MartijnVisser the issue is that `@SupressWarnings("deprecation")` are not considered by the maven-compiler-plugin and we have (somewhat recently) enabled strict failure on warnings:
   https://github.com/afedulov/flink/blob/master/flink-examples/flink-examples-streaming/pom.xml#L154-L155
   https://issues.apache.org/jira/browse/FLINK-24833
   
   There are two ways forward:
   1. Postpone marking SourceFunction as deprecated and push for finalizing [FLIP-238](https://cwiki.apache.org/confluence/display/FLINK/FLIP-238%3A+Introduce+FLIP-27-based+Data+Generator+Source) to migrate all existing sample sources
   2. Remove the `failOnWarning` parameter for now and add respective comments explaining the current state
   
   I would say that our original discussion on the ML converged in the direction that supports option 2. - mark SourceFunction as deprecated effective immediately to prevent its further spread and work on closing the gaps as a follow-up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1170874749

   @afedulov Will you do another round of rebasing or do you want me to help you out with that? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20049: [connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1163046742

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e3f9a5f5d9f30e495be4c6b8da021d0442f70fa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4e3f9a5f5d9f30e495be4c6b8da021d0442f70fa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4e3f9a5f5d9f30e495be4c6b8da021d0442f70fa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] reswqa merged pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #20049:
URL: https://github.com/apache/flink/pull/20049


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1165579663

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1386662086

   @afedulov since FLIP-238 had been resolved, shall we continue this work and make it done in flink-1.17 release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1189456851

   Update: this effort is currently pending the introduction of the FLIP-238 data generation sources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1405608732

   @afedulov Do you think you can still make it before the feature freeze? (That's the 31st of January). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [connectors] Mark SourceFunction interface as @Deprecated

Posted by GitBox <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1163063525

   @MartijnVisser that was quick :) 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1407641489

   @alpinegizmo Ha, good point. My guess is, it is used just because the name sounds good - like it does something interesting, but not overly complex. I do not think anyone actually looks into the details of the example when going through that documentation page and we can easily swap it for something else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "alpinegizmo (via GitHub)" <gi...@apache.org>.
alpinegizmo commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1407553971

   @afedulov I'm not a fan of the TopSpeedWindowing example -- it's not at all obvious what it's doing. I do like that it's a decent example of how to use the FileSource and FileSink, but the SideOutputExample covers that too.
   
   Personally, I'd be happy to drop TopSpeedWindowing. Any idea why it has been a popular example job? For example, if we drop it, then this section of the docs will need to be updated:
   
   https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/deployment/resource-providers/native_kubernetes/#starting-a-flink-session-on-kubernetes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1611123109

   @flinkbot run azure
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org