You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/04/26 01:33:12 UTC
[GitHub] [spark] itholic commented on a diff in pull request #40938: [SPARK-43274][SPARK-43275][PYTHON][CONNECT] Introduce `PySparkNotImplementedError`
itholic commented on code in PR #40938:
URL: https://github.com/apache/spark/pull/40938#discussion_r1177219630
##########
python/pyspark/errors/error_classes.py:
##########
@@ -269,6 +269,11 @@
"<objectName> is not iterable."
]
},
+ "NOT_LIST" : {
Review Comment:
Yes, we can classify error classes starting with `NOT_XXX` into one error class or group similar types of errors into a main-sub error class structure. Each way has its pros and cons, so we plan to proceed with the initial migration in the current form first, and then gather opinions from ppl through decision docs or something before making changes all at once.
BTW, we already have a [ticket](https://issues.apache.org/jira/browse/SPARK-43020) for this FYI :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org