You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "jrgemignani (via GitHub)" <gi...@apache.org> on 2024/04/11 17:07:33 UTC
[PR] Add helpful messages to the VLE subsystem [age]
jrgemignani opened a new pull request, #1742:
URL: https://github.com/apache/age/pull/1742
Added helpful messaging to the VLE subsystem.
These changes are due to issue 365 where there was an issue with the VLE that turned out to not be with the VLE. Basically, there is a way, apparently, to have a malformed edge or possibly one not fully removed. When the VLE subsystem does its load on the graph, it would error out on these edges as this was considered to be a potential data corruption issue.
The changes added are to report and ignore these edges. Reporting them, so as to allow the user to take corrective action by removing them. Ignoring them, as they are likely not relevant to the query. Basically, leaving it up to the user to decide.
No impact to current regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add helpful messages to the VLE subsystem [age]
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on code in PR #1742:
URL: https://github.com/apache/age/pull/1742#discussion_r1561860383
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -568,11 +610,13 @@ static void load_edge_hashtable(GRAPH_global_context *ggctx)
/* insert the edge into the start and end vertices edge lists */
inserted = insert_vertex_edge(ggctx, edge_vertex_start_id,
- edge_vertex_end_id, edge_id);
- /* this insert must not fail */
+ edge_vertex_end_id, edge_id,
+ edge_label_name);
if (!inserted)
Review Comment:
Overall looks good. Just a quick question. Does `!insert` always imply a `WARNING` instead of an `ERROR`?
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -568,11 +610,13 @@ static void load_edge_hashtable(GRAPH_global_context *ggctx)
/* insert the edge into the start and end vertices edge lists */
inserted = insert_vertex_edge(ggctx, edge_vertex_start_id,
- edge_vertex_end_id, edge_id);
- /* this insert must not fail */
+ edge_vertex_end_id, edge_id,
+ edge_label_name);
if (!inserted)
Review Comment:
Overall looks good. Just a quick question. Does `!inserted` always imply a `WARNING` instead of an `ERROR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add helpful messages to the VLE subsystem [age]
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on code in PR #1742:
URL: https://github.com/apache/age/pull/1742#discussion_r1561860383
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -568,11 +610,13 @@ static void load_edge_hashtable(GRAPH_global_context *ggctx)
/* insert the edge into the start and end vertices edge lists */
inserted = insert_vertex_edge(ggctx, edge_vertex_start_id,
- edge_vertex_end_id, edge_id);
- /* this insert must not fail */
+ edge_vertex_end_id, edge_id,
+ edge_label_name);
if (!inserted)
Review Comment:
Overall looks good. Just a quick questions. Does `!insert` always imply a `WARNING` instead of an `ERROR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add helpful messages to the VLE subsystem [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on code in PR #1742:
URL: https://github.com/apache/age/pull/1742#discussion_r1561862956
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -568,11 +610,13 @@ static void load_edge_hashtable(GRAPH_global_context *ggctx)
/* insert the edge into the start and end vertices edge lists */
inserted = insert_vertex_edge(ggctx, edge_vertex_start_id,
- edge_vertex_end_id, edge_id);
- /* this insert must not fail */
+ edge_vertex_end_id, edge_id,
+ edge_label_name);
if (!inserted)
Review Comment:
The only time `insert_vertex_edge` will fail to insert is if there is an issue with the edge's start and end vertices. This means a malformed or dangling edge. For these, we just want to notify the user via a warning, since there could be many. Allowing all of them to just warn makes it easier to fix them all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add helpful messages to the VLE subsystem [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on code in PR #1742:
URL: https://github.com/apache/age/pull/1742#discussion_r1561862956
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -568,11 +610,13 @@ static void load_edge_hashtable(GRAPH_global_context *ggctx)
/* insert the edge into the start and end vertices edge lists */
inserted = insert_vertex_edge(ggctx, edge_vertex_start_id,
- edge_vertex_end_id, edge_id);
- /* this insert must not fail */
+ edge_vertex_end_id, edge_id,
+ edge_label_name);
if (!inserted)
Review Comment:
The only time `insert_vertex_edge` will fail to insert is if there is an issue with the edge's start and end vertices. This means a malformed or dangling edge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add helpful messages to the VLE subsystem [age]
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 merged PR #1742:
URL: https://github.com/apache/age/pull/1742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org