[GitHub] [lucene] msokolov commented on a diff in pull request #1071: LUCENE-9583: Remove RandomAccessVectorValuesProducer

[GitBox <gi...@apache.org>]

msokolov commented on code in PR #1071:
URL: https://github.com/apache/lucene/pull/1071#discussion_r950507613


##########
lucene/core/src/java/org/apache/lucene/index/VectorValues.java:
##########
@@ -192,36 +176,5 @@ public int advance(int target) throws IOException {
     public long cost() {
       return size();
     }
-
-    @Override
-    public RandomAccessVectorValues randomAccess() throws IOException {

Review Comment:
   This is kind of funny to me since it is kind of back to a much earlier iteration where these were all on the same interface, but I split them apart as a way to  try and hide the random access that people didn't like :) Although it was never very successful. Anyway I am +1 to get rid of the fig leaf



##########
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##########
@@ -308,41 +302,6 @@ private void printFanoutHist(Path indexPath) throws IOException {
     }
   }
 
-  @SuppressWarnings("unchecked")
-  private void dumpGraph(Path docsPath) throws IOException {

Review Comment:
   hm I guess we can always restore. This had been pretty useful in early times when nothing was working ...



##########
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##########
@@ -783,66 +742,6 @@ private static void usage() {
     System.exit(1);
   }
 
-  class BinaryFileVectors implements RandomAccessVectorValuesProducer, Closeable {

Review Comment:
   if it's not used, I think we can remove?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org