[GitHub] [maven-plugin-tools] MartinKanters commented on a change in pull request #30: [MPLUGIN-367] Improve @Execute(lifecycle...) docs

[GitBox <gi...@apache.org>]

MartinKanters commented on a change in pull request #30:
URL: https://github.com/apache/maven-plugin-tools/pull/30#discussion_r528212117



##########
File path: maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Execute.java
##########
@@ -51,7 +51,8 @@
     String goal() default "";
 
     /**
-     * lifecycle id to fork.
+     * lifecycle id of the phase to fork. Only valid in combination with {@link #phase()}. If not specified, Maven will

Review comment:
       Great improvement already, but I think "lifecycle id of the phase to fork. " is still a bit too vague.
   Perhaps something like: "lifecycle id specifying which lifecycle the forked phase will run in."
   
   And should we refer to lifecycles.xml? http://maven.apache.org/ref/3.2.5/maven-plugin-api/lifecycle-mappings.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org