You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by hsyuan <gi...@git.apache.org> on 2016/11/03 11:13:10 UTC
[GitHub] incubator-hawq pull request #1001: HAWQ-1136. Disable .psqlrc in minirepro
GitHub user hsyuan opened a pull request:
https://github.com/apache/incubator-hawq/pull/1001
HAWQ-1136. Disable .psqlrc in minirepro
.psqlrc can create unexpected output and changes in formatting that don't play nice with parse_oids().
```
psql database --pset footer -Atq -h localhost -p 5432 -U gpadmin -f /tmp/20161012232709/toolkit.sql
{"relids": "573615536", "funcids": ""}
Time: 2.973 ms
```
Generates an Exception:
```
Traceback (most recent call last):
File "/usr/local/greenplum-db/./bin/minirepro", line 386, in <module>
main()
File "/usr/local/greenplum-db/./bin/minirepro", line 320, in main
mr_query = parse_oids(cursor, json_str)
File "/usr/local/greenplum-db/./bin/minirepro", line 151, in parse_oids
result.relids = json.loads(json_oids)['relids']
File "/usr/local/greenplum-db/ext/python/lib/python2.6/json/__init__.py", line 307, in loads
return _default_decoder.decode(s)
File "/usr/local/greenplum-db/ext/python/lib/python2.6/json/decoder.py", line 322, in decode
raise ValueError(errmsg("Extra data", s, end, len(s)))
ValueError: Extra data: line 2 column 1 - line 3 column 1 (char 39 - 54)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsyuan/incubator-hawq HAWQ-1136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1001.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1001
----
commit 4a9eb3f513fef7b1d483de46fb7462b2013864d7
Author: Haisheng Yuan <hy...@pivotal.io>
Date: 2016-11-03T11:05:14Z
HAWQ-1136. Disable .psqlrc in minirepro
.psqlrc can create unexpected output and changes in formatting that don't play nice with parse_oids().
```
psql database --pset footer -Atq -h localhost -p 5432 -U gpadmin -f /tmp/20161012232709/toolkit.sql
{"relids": "573615536", "funcids": ""}
Time: 2.973 ms
```
Generates an Exception:
```
Traceback (most recent call last):
File "/usr/local/greenplum-db/./bin/minirepro", line 386, in <module>
main()
File "/usr/local/greenplum-db/./bin/minirepro", line 320, in main
mr_query = parse_oids(cursor, json_str)
File "/usr/local/greenplum-db/./bin/minirepro", line 151, in parse_oids
result.relids = json.loads(json_oids)['relids']
File "/usr/local/greenplum-db/ext/python/lib/python2.6/json/__init__.py", line 307, in loads
return _default_decoder.decode(s)
File "/usr/local/greenplum-db/ext/python/lib/python2.6/json/decoder.py", line 322, in decode
raise ValueError(errmsg("Extra data", s, end, len(s)))
ValueError: Extra data: line 2 column 1 - line 3 column 1 (char 39 - 54)
```
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1001: HAWQ-1136. Disable .psqlrc in minirepro
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/1001
@hysuan - Are there any plans to continue working on this PR? There hasn't been any activity on this PR or the corresponding Jira (HAWQ-1136) since Nov 2016.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1001: HAWQ-1136. Disable .psqlrc in minirepro
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1001
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1001: HAWQ-1136. Disable .psqlrc in minirepro
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1001
@hsyuan, It seems that you skip checking about something. It is better to fix the root cause of this exception instead of skipping checking. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1001: HAWQ-1136. Disable .psqlrc in minirepro
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1001
looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1001: HAWQ-1136. Disable .psqlrc in minirepro
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/1001
@paul-guo- @linwen @liming01 Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---