You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/05/28 09:04:47 UTC
Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in portable ip
test cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-6780
https://issues.apache.org/jira/browse/CLOUDSTACK-6780
Repository: cloudstack-git
Description
-------
Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
Diffs
-----
test/integration/component/test_portable_ip.py 847bb4a
Diff: https://reviews.apache.org/r/21973/diff/
Testing
-------
Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
ok
Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
ok
Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 263.215s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in
portable ip test cases
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/#review45341
-----------------------------------------------------------
Commit dd26d4db63aa42da9da7bea0a31c541760c74125 in cloudstack's branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=dd26d4d ]
CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases
- ASF Subversion and Git Services
On June 10, 2014, 11:16 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21973/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 11:16 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6780
> https://issues.apache.org/jira/browse/CLOUDSTACK-6780
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 847bb4a
>
> Diff: https://reviews.apache.org/r/21973/diff/
>
>
> Testing
> -------
>
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
> ok
> Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
> ok
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 263.215s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in
portable ip test cases
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/#review45337
-----------------------------------------------------------
Commit 0190c936689fc252e51b7c412283c128b5386b24 in cloudstack's branch refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0190c93 ]
CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases
- ASF Subversion and Git Services
On June 10, 2014, 11:16 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21973/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 11:16 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6780
> https://issues.apache.org/jira/browse/CLOUDSTACK-6780
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 847bb4a
>
> Diff: https://reviews.apache.org/r/21973/diff/
>
>
> Testing
> -------
>
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
> ok
> Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
> ok
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 263.215s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in
portable ip test cases
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/#review45256
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On June 10, 2014, 11:16 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21973/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 11:16 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6780
> https://issues.apache.org/jira/browse/CLOUDSTACK-6780
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 847bb4a
>
> Diff: https://reviews.apache.org/r/21973/diff/
>
>
> Testing
> -------
>
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
> ok
> Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
> ok
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 263.215s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in
portable ip test cases
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/
-----------------------------------------------------------
(Updated June 10, 2014, 11:16 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Santhosh, please take a look at updated patch.
Bugs: CLOUDSTACK-6780
https://issues.apache.org/jira/browse/CLOUDSTACK-6780
Repository: cloudstack-git
Description
-------
Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
Diffs
-----
test/integration/component/test_portable_ip.py 847bb4a
Diff: https://reviews.apache.org/r/21973/diff/
Testing
-------
Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
ok
Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
ok
Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 263.215s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in
portable ip test cases
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/
-----------------------------------------------------------
(Updated May 28, 2014, 9:38 a.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Updated patch.
Bugs: CLOUDSTACK-6780
https://issues.apache.org/jira/browse/CLOUDSTACK-6780
Repository: cloudstack-git
Description
-------
Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
Diffs (updated)
-----
test/integration/component/test_portable_ip.py 847bb4a
Diff: https://reviews.apache.org/r/21973/diff/
Testing
-------
Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
ok
Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
ok
Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 263.215s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in
portable ip test cases
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On May 28, 2014, 7:09 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_portable_ip.py, line 1118
> > <https://reviews.apache.org/r/21973/diff/1/?file=597289#file597289line1118>
> >
> > Here, we are deleting with api_client_user, but in finally self.apiclient. Is that the purpose?
We are trying to delete with api client of the account which was not used to create IP address. This should fail. And then before test case returns, we must delete ip with api client of account which was used to create it (in this case self.apiclient), so that all IP addresses are disassociated and IP range gets deleted successfully in cleanup.
> On May 28, 2014, 7:09 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_portable_ip.py, line 1123
> > <https://reviews.apache.org/r/21973/diff/1/?file=597289#file597289line1123>
> >
> > same entity is getting deleting both in try\finally. This case can happen when there is no exception thrown from CS and it will hit try and then finally. It will lead to exception again.
You are right, we should have it only in try block. Corrected in upadated patch.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/#review44103
-----------------------------------------------------------
On May 28, 2014, 9:38 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21973/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 9:38 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-6780
> https://issues.apache.org/jira/browse/CLOUDSTACK-6780
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 847bb4a
>
> Diff: https://reviews.apache.org/r/21973/diff/
>
>
> Testing
> -------
>
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
> ok
> Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
> ok
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 263.215s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in
portable ip test cases
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/#review44103
-----------------------------------------------------------
test/integration/component/test_portable_ip.py
<https://reviews.apache.org/r/21973/#comment78429>
Here, we are deleting with api_client_user, but in finally self.apiclient. Is that the purpose?
test/integration/component/test_portable_ip.py
<https://reviews.apache.org/r/21973/#comment78430>
same entity is getting deleting both in try\finally. This case can happen when there is no exception thrown from CS and it will hit try and then finally. It will lead to exception again.
- Santhosh Edukulla
On May 28, 2014, 7:04 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21973/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 7:04 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-6780
> https://issues.apache.org/jira/browse/CLOUDSTACK-6780
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup.
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py 847bb4a
>
> Diff: https://reviews.apache.org/r/21973/diff/
>
>
> Testing
> -------
>
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS ===
> ok
> Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS ===
> ok
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 3 tests in 263.215s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>