You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/17 08:29:41 UTC
[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #203: Change default podManagementPolicy to Parallel for Zookeeper
lhotari opened a new pull request #203:
URL: https://github.com/apache/pulsar-helm-chart/pull/203
### Motivation
- For speeding up startup, podManagementPolicy should be set to `Parallel` for Zookeeper
### Modifications
- set `zookeeper.podManagementPolicy` to `Parallel` in the default `values.yaml` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari merged pull request #203: Change default podManagementPolicy to Parallel for Zookeeper
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #203:
URL: https://github.com/apache/pulsar-helm-chart/pull/203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #203: Change default podManagementPolicy to Parallel for Zookeeper
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #203:
URL: https://github.com/apache/pulsar-helm-chart/pull/203#issuecomment-1051068932
@rmyates - thank you for posting this message. This change was intended to be backwards compatible, so it is valuable feedback to know it wasn't. Now that we've changed the default, I don't believe we can go back without also breaking new deployments that inherited the `Parallel` default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] rmyates commented on pull request #203: Change default podManagementPolicy to Parallel for Zookeeper
Posted by GitBox <gi...@apache.org>.
rmyates commented on pull request #203:
URL: https://github.com/apache/pulsar-helm-chart/pull/203#issuecomment-1050973199
Note for future googlers, this change will break a helm chart upgrade if you installed the chart before this change due to podManagementPolicy in a StatefulSet being an immutable field.
> Error: UPGRADE FAILED: cannot patch "pulsar-zookeeper" with kind StatefulSet: StatefulSet.apps "pulsar-zookeeper" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden
Set it back to the previous version with the below in your custom values file which I don't think does any harm for existing installs
```
zookeeper:
# Changed to Parallel by default in https://github.com/apache/pulsar-helm-chart/pull/203
# However since we installed the chart prior to this and this field is immutable
# set it back to the old value.
podManagementPolicy: OrderedReady
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] rmyates commented on pull request #203: Change default podManagementPolicy to Parallel for Zookeeper
Posted by GitBox <gi...@apache.org>.
rmyates commented on pull request #203:
URL: https://github.com/apache/pulsar-helm-chart/pull/203#issuecomment-1051086894
@michaeljmarshall No worries. I think keeping the change for new users/installs is fine and does make sense looking at the [k8s docs](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#parallel-pod-management).
It's just one of those things where an immutable field bites you every now and then! I suspect they aired on the side of caution with changes to existing StatefulSets given the potential for destruction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org