You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/12/03 23:57:23 UTC

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

Jackie-Jiang commented on a change in pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#discussion_r535733881



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
##########
@@ -81,6 +81,7 @@ private static void setupHelixClusterIfNeeded(String helixClusterName, String zk
       configMap.put(DEFAULT_HYPERLOGLOG_LOG2M_KEY, Integer.toString(DEFAULT_HYPERLOGLOG_LOG2M));
       configMap.put(CommonConstants.Broker.CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE, Boolean.toString(false));
       admin.setConfig(configScope, configMap);
+      admin.close();

Review comment:
       You need to close it in both cases? (Move it out of the else block)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org