You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Dan Diephouse (JIRA)" <ji...@codehaus.org> on 2005/04/19 22:09:01 UTC
[jira] Created: (MNG-325) Do something about interpolated values in
dependencies
Do something about interpolated values in dependencies
------------------------------------------------------
Key: MNG-325
URL: http://jira.codehaus.org/browse/MNG-325
Project: m2
Type: Sub-task
Reporter: Dan Diephouse
In the xfire poms, we extend the parent and have ${pom.currentVersion} in the version field for a lot of the dependencies. M2 chokes on these. Maybe these dependencies can be thrown out? Maybe pom.currentVersion can be filled in automatically?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-325) Do something about interpolated values in dependencies
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-325?page=comments#action_38370 ]
Brett Porter commented on MNG-325:
----------------------------------
Dan, sorry I wasn't totally clear about my intentions. I think we might be doing additional work in this space in relation to a full repository app, just not in the scope of the current tool.
I didn't think removing extend was really going to help here? Is there a pom coming through that is invalid?
Also, I'd rather not remove dependencies if we can avoid it. But the main driver there is the amount of work involved, and that would be pushed to a bigger project as well.
Some specific examples of things could be improved - eg filling in pom variables as you say (though not if the version is inherited) - if you have any examples, feel free to bring them up.
> Do something about interpolated values in dependencies
> ------------------------------------------------------
>
> Key: MNG-325
> URL: http://jira.codehaus.org/browse/MNG-325
> Project: m2
> Type: Sub-task
> Reporter: Dan Diephouse
> Assignee: John Casey
>
>
> In the xfire poms, we extend the parent and have ${pom.currentVersion} in the version field for a lot of the dependencies. M2 chokes on these. Maybe these dependencies can be thrown out? Maybe pom.currentVersion can be filled in automatically?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-325) Do something about interpolated values
in dependencies
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-325?page=comments#action_37800 ]
John Casey commented on MNG-325:
--------------------------------
If these are maven-1 pom's and they extend something, we probably can't reliably convert it to a maven-2 pom, since the <extends/> element uses local filesystem paths.
In certain (probably rare) cases, if the parent is specified as:
${maven.repo.local}/myGroup/poms/myArtifact-version.pom
then it's possible that we may be able to extract the parent pom info and look it up in the repository. This is not currently enabled, however.
I'll look into the specific cases for xfire, and we can probably add some measure of interpolation, but be aware that the extends stuff will probably never work reliably.
> Do something about interpolated values in dependencies
> ------------------------------------------------------
>
> Key: MNG-325
> URL: http://jira.codehaus.org/browse/MNG-325
> Project: m2
> Type: Sub-task
> Reporter: Dan Diephouse
> Assignee: John Casey
>
>
> In the xfire poms, we extend the parent and have ${pom.currentVersion} in the version field for a lot of the dependencies. M2 chokes on these. Maybe these dependencies can be thrown out? Maybe pom.currentVersion can be filled in automatically?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-325) Do something about interpolated values
in dependencies
Posted by "Dan Diephouse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-325?page=comments#action_37803 ]
Dan Diephouse commented on MNG-325:
-----------------------------------
I'm not really asking for interopolation to work. I'm just asking that you don't let invalid maven 2 poms go into the repo. Invalid meaning the dependencies specified don't exist. XOM 1.0b3 depends on stuff that doesn't exist as well. It depends on icu4j which isn't in the repo at all.
Granted, some dependencies like javamail will never exist in the repo. So I'm not sure quite what the action should be. I guess if any elements fit the pattern of ${...} I think they should be taken out.
> Do something about interpolated values in dependencies
> ------------------------------------------------------
>
> Key: MNG-325
> URL: http://jira.codehaus.org/browse/MNG-325
> Project: m2
> Type: Sub-task
> Reporter: Dan Diephouse
> Assignee: John Casey
>
>
> In the xfire poms, we extend the parent and have ${pom.currentVersion} in the version field for a lot of the dependencies. M2 chokes on these. Maybe these dependencies can be thrown out? Maybe pom.currentVersion can be filled in automatically?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-325) Do something about interpolated values in dependencies
Posted by "Dan Diephouse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-325?page=comments#action_38124 ]
Dan Diephouse commented on MNG-325:
-----------------------------------
I don't understand why you can't at least just remove the <extend> element or remove the <dependency>... It seems like a valid POM is better than an invalid POM even if it is missing some info. And the issue isn't always evangalism - in XFire we use interpolated values to make the reactor work. Is there something I'm missing?
> Do something about interpolated values in dependencies
> ------------------------------------------------------
>
> Key: MNG-325
> URL: http://jira.codehaus.org/browse/MNG-325
> Project: m2
> Type: Sub-task
> Reporter: Dan Diephouse
> Assignee: John Casey
>
>
> In the xfire poms, we extend the parent and have ${pom.currentVersion} in the version field for a lot of the dependencies. M2 chokes on these. Maybe these dependencies can be thrown out? Maybe pom.currentVersion can be filled in automatically?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-325) Do something about interpolated values in dependencies
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-325?page=all ]
Brett Porter closed MNG-325:
----------------------------
Resolution: Won't Fix
we're doing what we can about dud artifacts like javamail. We can't do much more in relation to the <extends/> issue other than evangelise other projects.
> Do something about interpolated values in dependencies
> ------------------------------------------------------
>
> Key: MNG-325
> URL: http://jira.codehaus.org/browse/MNG-325
> Project: m2
> Type: Sub-task
> Reporter: Dan Diephouse
> Assignee: John Casey
>
>
> In the xfire poms, we extend the parent and have ${pom.currentVersion} in the version field for a lot of the dependencies. M2 chokes on these. Maybe these dependencies can be thrown out? Maybe pom.currentVersion can be filled in automatically?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org