You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/17 07:47:25 UTC

[GitHub] [airflow] turbaszek commented on pull request #9861: Add test for GCSTaskHandler (#9600)

turbaszek commented on pull request #9861:
URL: https://github.com/apache/airflow/pull/9861#issuecomment-674720419


   @OmairK I run those tests and this change looks good! I only have a question regarding the subprocess call.
   
   Btw. would you mind getting rid of this warning:
   ```
     /opt/airflow/airflow/providers/google/cloud/log/gcs_task_handler.py:53: DeprecationWarning: The google_cloud_storage_conn_id parameter has been deprecated. You should pass the gcp_conn_id parameter.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org