You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/08/10 20:41:18 UTC
Review Request 61580: Extracted JNI code into a protected function for
clarity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7872
https://issues.apache.org/jira/browse/MESOS-7872
Repository: mesos
Description
-------
Extracted JNI code into a protected function for clarity.
Diffs
-----
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411
Diff: https://reviews.apache.org/r/61580/diff/1/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 61580: Extracted JNI code into a protected
function for clarity.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/#review182687
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61579, 61580]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 10, 2017, 8:41 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61580/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 8:41 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7872
> https://issues.apache.org/jira/browse/MESOS-7872
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411
>
>
> Diff: https://reviews.apache.org/r/61580/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61580: Extracted JNI code into a protected
function for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/
-----------------------------------------------------------
(Updated Aug. 31, 2017, 7:09 a.m.)
Review request for mesos, Anand Mazumdar, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7872
https://issues.apache.org/jira/browse/MESOS-7872
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411
Diff: https://reviews.apache.org/r/61580/diff/3/
Changes: https://reviews.apache.org/r/61580/diff/2-3/
Testing
-------
make check
Manual tests using a [modified hello-world framework](https://github.com/mesosphere/dcos-commons/commit/ba60999cc2545f98fb935e114d20727b441286ed) from DC/OS' SDK.
Thanks,
Alexander Rukletsov
Re: Review Request 61580: Extracted JNI code into a protected
function for clarity.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/#review184204
-----------------------------------------------------------
Ship it!
Thanks for the cleanup!
- Anand Mazumdar
On Aug. 30, 2017, 2:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61580/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 2:16 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7872
> https://issues.apache.org/jira/browse/MESOS-7872
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411
>
>
> Diff: https://reviews.apache.org/r/61580/diff/2/
>
>
> Testing
> -------
>
> make check
> Manual tests using a [modified hello-world framework](https://github.com/mesosphere/dcos-commons/commit/ba60999cc2545f98fb935e114d20727b441286ed) from DC/OS' SDK.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61580: Extracted JNI code into a protected
function for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/
-----------------------------------------------------------
(Updated Aug. 30, 2017, 2:16 p.m.)
Review request for mesos, Anand Mazumdar, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7872
https://issues.apache.org/jira/browse/MESOS-7872
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411
Diff: https://reviews.apache.org/r/61580/diff/2/
Changes: https://reviews.apache.org/r/61580/diff/1-2/
Testing (updated)
-------
make check
Manual tests using a [modified hello-world framework](https://github.com/mesosphere/dcos-commons/commit/ba60999cc2545f98fb935e114d20727b441286ed) from DC/OS' SDK.
Thanks,
Alexander Rukletsov
Re: Review Request 61580: Extracted JNI code into a protected
function for clarity.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/#review182710
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61579, 61580]
Logs available here: http://104.210.40.105/logs/master/61580
- Mesos Reviewbot Windows
On Aug. 10, 2017, 8:41 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61580/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 8:41 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7872
> https://issues.apache.org/jira/browse/MESOS-7872
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411
>
>
> Diff: https://reviews.apache.org/r/61580/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61580: Extracted JNI code into a protected
function for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/
-----------------------------------------------------------
(Updated Aug. 10, 2017, 8:41 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7872
https://issues.apache.org/jira/browse/MESOS-7872
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411
Diff: https://reviews.apache.org/r/61580/diff/1/
Testing
-------
make check
Thanks,
Alexander Rukletsov