You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/10 15:50:50 UTC
[GitHub] [superset] RoBYCoNTe opened a new pull request, #22090: fix(embedded): legacy PivotTable with undefined jQuery ($)
RoBYCoNTe opened a new pull request, #22090:
URL: https://github.com/apache/superset/pull/22090
### SUMMARY
Legacy PivotTable throw an invalid exception caused by missing jQuery library in to embedded template.
I just added missing script tag to avoid this problem. I know this is a legacy plugin that will be dismissed by I consider it very usefull (and graphically acceptable) and I suppose that someone else can use it too.
### TESTING INSTRUCTIONS
Add new Pivot Table in to public dashboard, try to load the dashboard outside superset and you will receive an errors in the box choosen to display the PivotTable.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] prnth22 commented on pull request #22090: fix(embedded): legacy PivotTable with undefined jQuery ($)
Posted by GitBox <gi...@apache.org>.
prnth22 commented on PR #22090:
URL: https://github.com/apache/superset/pull/22090#issuecomment-1346043831
@RoBYCoNTe
Please check this
https://apache-superset.slack.com/archives/C01EP56QGTS/p1670009674370889?thread_ts=1669812772.543539&cid=C01EP56QGTS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] RoBYCoNTe commented on pull request #22090: fix(embedded): legacy PivotTable with undefined jQuery ($)
Posted by GitBox <gi...@apache.org>.
RoBYCoNTe commented on PR #22090:
URL: https://github.com/apache/superset/pull/22090#issuecomment-1313323962
I've to cancel this pull request, adding the jquery script the usage of basic flask template seems to be corrupted, I've to check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] RoBYCoNTe closed pull request #22090: fix(embedded): legacy PivotTable with undefined jQuery ($)
Posted by GitBox <gi...@apache.org>.
RoBYCoNTe closed pull request #22090: fix(embedded): legacy PivotTable with undefined jQuery ($)
URL: https://github.com/apache/superset/pull/22090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org