You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2025/09/14 05:02:03 UTC

(shardingsphere) branch master updated: Remove useless getter on DockerStorageContainer (#36562)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new a012331d007 Remove useless getter on DockerStorageContainer (#36562)
a012331d007 is described below

commit a012331d007a3c69cfaaae02e34933ff8eb0c332
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun Sep 14 13:01:57 2025 +0800

    Remove useless getter on DockerStorageContainer (#36562)
---
 .../container/atomic/storage/type/docker/DockerStorageContainer.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/atomic/storage/type/docker/DockerStorageContainer.java b/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/atomic/storage/type/docker/DockerStorageContainer.java
index 0cef9991f14..7dab49c6e73 100644
--- a/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/atomic/storage/type/docker/DockerStorageContainer.java
+++ b/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/atomic/storage/type/docker/DockerStorageContainer.java
@@ -46,7 +46,6 @@ import java.util.stream.Collectors;
 /**
  * Docker storage container.
  */
-@Getter
 public abstract class DockerStorageContainer extends DockerITContainer implements StorageContainer {
     
     private final DatabaseType databaseType;
@@ -55,8 +54,10 @@ public abstract class DockerStorageContainer extends DockerITContainer implement
     
     private final int majorVersion;
     
+    @Getter
     private final Map<String, DataSource> actualDataSourceMap = new LinkedHashMap<>();
     
+    @Getter
     private final Map<String, DataSource> expectedDataSourceMap = new LinkedHashMap<>();
     
     protected DockerStorageContainer(final DatabaseType databaseType, final String containerImage, final StorageContainerConfiguration storageContainerConfig) {
@@ -132,7 +133,7 @@ public abstract class DockerStorageContainer extends DockerITContainer implement
      * @return JDBC URL
      */
     public final String getJdbcUrl(final String dataSourceName) {
-        return DataSourceEnvironment.getURL(getDatabaseType(), getHost(), getMappedPort(),
+        return DataSourceEnvironment.getURL(databaseType, getHost(), getMappedPort(),
                 Strings.isNullOrEmpty(dataSourceName) ? storageContainerConfig.getConfigurationOption().getDefaultDatabaseName(majorVersion).orElse("") : dataSourceName);
     }