[GitHub] [zeppelin] zjffdu commented on issue #3498: [ZEPPELIN-4409] Set spark.app.name to know which user is running which notebook

[GitBox <gi...@apache.org>]

zjffdu commented on issue #3498: [ZEPPELIN-4409] Set spark.app.name to know which user is running which notebook
URL: https://github.com/apache/zeppelin/pull/3498#issuecomment-562011749
 
 
   
   > If `spark.app.name` is already set, should we leave it as it is or add username and note id also ? if we leave it, all users and notes shall still have the same name, i don't think that's what we want to see. So I think the logic here could be like this:
   > 
   > 1. if `spark.app.name` is not set or set to blank, we set it to `Zeppelin_` + `interpreter_name` + `username` + `noteId`, and `interpreter_name` is actually `spark`, so it is `Zeppelin_spark_` + `username` + `noteId`.
   > 2. if `spark.app.name` is already set to a string, noted by `APP_NAME`, in this case, we set it to `APP_NAME` + `username` + `noteId`.
   >    @zjffdu
   
   1. We could use `Zeppelin_` + interpreter_group_name which may contains note id and user name which depends on the interpreter mode. (See https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java#L422)
   2. I think it is fine to leave `spark.app.name` as what it is set when user set it explicitly. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services