You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/05 00:37:49 UTC

[GitHub] [arrow] terencehonles opened a new pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

terencehonles opened a new pull request #8595:
URL: https://github.com/apache/arrow/pull/8595


   `OrcStripeReaderJniWrapper::getSchema` previously used `nullptr` for the memory pool parameter to `arrow::ipc::SerializeSchema` to implicitly call `arrow::default_memory_pool()`.
   
   As part of https://issues.apache.org/jira/browse/ARROW-10080, a check was placed to fail on `nullptr` being provided. This change removes the check, but also explicitly calls `arrow::default_memory_pool()` which is used elsewhere in the JNI wrapper.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8595:
URL: https://github.com/apache/arrow/pull/8595#issuecomment-722056096


   https://issues.apache.org/jira/browse/ARROW-10499


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8595:
URL: https://github.com/apache/arrow/pull/8595#issuecomment-722146920


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] BryanCutler commented on pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8595:
URL: https://github.com/apache/arrow/pull/8595#issuecomment-722664541


   Thanks for fixing this @terencehonles !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

Posted by GitBox <gi...@apache.org>.
kou closed pull request #8595:
URL: https://github.com/apache/arrow/pull/8595


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8595:
URL: https://github.com/apache/arrow/pull/8595#issuecomment-722574077


   I do not have the grant to merge it. I expect that others will look at this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kiszk edited a comment on pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

Posted by GitBox <gi...@apache.org>.
kiszk edited a comment on pull request #8595:
URL: https://github.com/apache/arrow/pull/8595#issuecomment-722574077


   I do not have the grant to merge it, too. I expect that others will look at this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] terencehonles commented on pull request #8595: ARROW-10499: [C++][Java] Fix ORC Java JNI Crash

Posted by GitBox <gi...@apache.org>.
terencehonles commented on pull request #8595:
URL: https://github.com/apache/arrow/pull/8595#issuecomment-722570789


   @kiszk you mind merging this in? Not sure if anything else needs to happen, but I don't have write access to the repo :slightly_smiling_face: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org