[GitHub] Tmin10 commented on a change in pull request #6914: [FLINK-10604] Add REMAINDER math function supported in Table API and SQL

[GitBox <gi...@apache.org>]

Tmin10 commented on a change in pull request #6914: [FLINK-10604] Add REMAINDER math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6914#discussion_r228865174
 
 

 ##########
 File path: docs/dev/table/functions.md
 ##########
 @@ -1094,6 +1094,17 @@ MOD(numeric1, numeric2)
         <p>Returns the remainder (modulus) of <i>numeric1</i> divided by <i>numeric2</i>. The result is negative only if <i>numeric1</i> is negative.</p>
       </td>
     </tr>
+    
+    <tr>
+      <td>
+        {% highlight text %}
+REMAINDER(numeric1, numeric2)
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns the remainder of <i>numeric1</i> divided by <i>numeric2</i>. The remainder value is equal to f1 - f2 × n where <i>n</i> is the integer closest to the exact value of the quotient f1/f2, and if two integers are equally close to f1/f2, then <i>n</i> is the integer that is even.</p>
 
 Review comment:
   I add two samples in javadoc and documentation. It's should clarify function usage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services