You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "mrhbj (via GitHub)" <gi...@apache.org> on 2024/08/19 14:09:49 UTC
[PR] Change the switch statement(#13666) [lucene]
mrhbj opened a new pull request, #13669:
URL: https://github.com/apache/lucene/pull/13669
### Description
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Change the switch statement(#13666) [lucene]
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #13669:
URL: https://github.com/apache/lucene/pull/13669#issuecomment-2297481110
Looks good, thanks! I'm OK with merging this, but I want to also take a moment to ask that we're somewhat cautious with racking up lots of small changes like this that cannot be back-ported onto 9.x (which still uses java11 as a min requirement, which doesn't support this style switch). Lots of divergences like this can make back-porting bug fixes or other impactful changes harder, so I'd like us to keep that in mind. Since we're close to a 10.0 and last-9.x release, I'm OK with this though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Change the switch statement(#13666) [lucene]
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller merged PR #13669:
URL: https://github.com/apache/lucene/pull/13669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org