You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jugomezv (via GitHub)" <gi...@apache.org> on 2023/03/07 18:59:08 UTC

[GitHub] [pinot] jugomezv commented on a diff in pull request #10387: Add look-back support for MergeRollupTask

jugomezv commented on code in PR #10387:
URL: https://github.com/apache/pinot/pull/10387#discussion_r1128409848


##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -260,9 +270,13 @@ public List<PinotTaskConfig> generateTasks(List<TableConfig> tableConfigs) {
         // Get watermark from MergeRollupTaskMetadata ZNode

Review Comment:
   May be this comment goes into the if now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org