You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/29 12:44:10 UTC
[GitHub] [beam] piotr-szuberski edited a comment on pull request #12838: [WIP][BEAM-10892] Add Proto support to Kafka Table Provider
piotr-szuberski edited a comment on pull request #12838:
URL: https://github.com/apache/beam/pull/12838#issuecomment-700676777
There is a problem here though. The checker says to use vendored proto library but the extensions/protobuf uses the normal one. How is that possible that it's fine there and it's a bug in extensions/sql?
And for example ProtoCoder<T> requires T to extend com.google.protobuf.Message while this is forbidden.
Should I create another PR replacing normal protobuf library with the vendored one in extensions/protobuf or is there a reason not to use vendored grpc library there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org