You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 10:47:55 UTC

[GitHub] [flink] kl0u commented on a change in pull request #13699: [FLINK-19154] ApplicationDispatcherBootstrap clean up HA data only when necessary

kl0u commented on a change in pull request #13699:
URL: https://github.com/apache/flink/pull/13699#discussion_r509178005



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -208,7 +210,8 @@ public void onStart() throws Exception {
 			throw exception;
 		}
 
-		dispatcherBootstrap.initialize(this, this.getRpcService().getScheduledExecutor());
+		this.dispatcherBootstrap = this.dispatcherBootstrapFactory.apply(shutDownFuture::completeExceptionally);

Review comment:
       The reason for this is that this would bubble up to `ClusterEntrypoint` calling `System.exit(RUNTIME_FAILURE_RETURN_CODE);` and I do not know if this will kill that cluster without deleting the HA data. 
   
   If this is this the contract, then I can do it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org