[GitHub] [openwhisk] style95 commented on a diff in pull request #5278: Prepare to integrate new scheduler into apache/openwhisk-deploy-kube

[GitBox <gi...@apache.org>]

style95 commented on code in PR #5278:
URL: https://github.com/apache/openwhisk/pull/5278#discussion_r962411907


##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala:
##########
@@ -289,6 +292,11 @@ object Scheduler {
 
     implicit val logger = new AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
 
+    if (useClusterBootstrap) {
+      AkkaManagement(actorSystem).start()
+      ClusterBootstrap(actorSystem).start()
+    }

Review Comment:
   > I believe my proposed changes work just fine with seed nodes (in the single-replica controller and scheduler deployments with Kubernetes
   
   This is where I feel we are not on the same page.
   In my downstream, we are running controllers and schedulers with more than 1 replica without any issue.
   But anyway, I don't want to impede this PR from being merged.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org