You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by "volosied (via GitHub)" <gi...@apache.org> on 2023/02/01 19:35:31 UTC

[GitHub] [myfaces] volosied commented on pull request #502: Fixes for TCK 790 on main

volosied commented on PR #502:
URL: https://github.com/apache/myfaces/pull/502#issuecomment-1412615967

   Thank you for all your hard work on this.  Glad to see it's finally passing. I think we should be at 100% for the TCK with this change now :) 
   
   As for the PR, it looks like it could be rebased since it contains older commits? 
   
   I also created this small commit for caching the prefix if you wanted to use it: https://github.com/volosied/myfaces/commit/22d451c7b7a7f01b16060d21a5563205680b7975
   
   It should keep things in the current faces context until it's released. 
   
   https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/context/facescontext#getAttributes() 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org