You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/09 04:09:37 UTC

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15993: [client][python] Add support for consumer get_last_message_id

BewareMyPower commented on code in PR #15993:
URL: https://github.com/apache/pulsar/pull/15993#discussion_r893050813


##########
pulsar-client-cpp/include/pulsar/Consumer.h:
##########
@@ -390,6 +390,11 @@ class PULSAR_PUBLIC Consumer {
      */
     bool isConnected() const;
 
+    /**
+     * Get the latest message id for the consumer's topic.
+     */
+    virtual void getLastMessageIdAsync(BrokerGetLastMessageIdCallback callback);

Review Comment:
   `BrokerGetLastMessageIdCallback` is an internal callback definition defined in `ConsumerImpl.h`, you should define your own callback. See `include/pulsar/Reader.h` for how it defines the `getLastMessageIdAsync`. And there is no need to make it `virtual`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org