You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/13 18:57:26 UTC

[GitHub] [kafka] mumrah commented on a change in pull request #11040: KAFKA-13078: Closing FileRawSnapshotWriter too early

mumrah commented on a change in pull request #11040:
URL: https://github.com/apache/kafka/pull/11040#discussion_r669029695



##########
File path: raft/src/main/java/org/apache/kafka/raft/FollowerState.java
##########
@@ -137,11 +137,11 @@ public boolean updateHighWatermark(OptionalLong highWatermark) {
         return fetchingSnapshot;
     }
 
-    public void setFetchingSnapshot(Optional<RawSnapshotWriter> fetchingSnapshot) {
+    public void setFetchingSnapshot(Optional<RawSnapshotWriter> newSnapshot) {
         if (fetchingSnapshot.isPresent()) {
             fetchingSnapshot.get().close();
         }

Review comment:
       Ok, so previously we were closing whatever snapshot was passed in to `setFetchingSnapshot?` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org