You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/09/06 23:58:42 UTC

[GitHub] spark pull request #19150: [SPARK-21939][TEST] Use TimeLimits instead of Tim...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/19150

    [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

    ## What changes were proposed in this pull request?
    
    Since ScalaTest 3.0.0, `org.scalatest.concurrent.TimeLimits` is deprecated.
    This PR replaces the deprecated one with `org.scalatest.concurrent.TimeLimits`.
    
    ```scala
    -import org.scalatest.concurrent.Timeouts._
    +import org.scalatest.concurrent.TimeLimits._
    ```
    
    ## How was this patch tested?
    
    Pass the existing test suites.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-21939

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19150
    
----
commit ab339b31b311035ebb75e8f079000d306cab16b8
Author: Dongjoon Hyun <do...@apache.org>
Date:   2017-09-06T23:22:11Z

    [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Thank you for review, @srowen ! :)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Retest this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81494/testReport)** for PR 19150 at commit [`678d1b2`](https://github.com/apache/spark/commit/678d1b214f2d8cec72b47782177e406cbab9f5ee).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    LGTM, there's a typo in PR description, "Timeouts is deprecated." not "TimeLimits".


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Merging to master, thanks @dongjoon-hyun .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81501/testReport)** for PR 19150 at commit [`678d1b2`](https://github.com/apache/spark/commit/678d1b214f2d8cec72b47782177e406cbab9f5ee).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Oh, I see. Thank you so much. I'll add that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Looks `stop ensures correct shutdown` in `BlockGeneratorSuite` is dependent on interrupting - http://www.scalatest.org/release_notes/3.0.0:
    
    > If you were relying on the default behavior of interrupting a thread on the JVM in ScalaTest 2.2.x, you'll need to define an implicit val referring to a `ThreadSignaler`
    
    ScalaTest looks they changed the default for good reasons bug looks we should explicitly set `ThreadSignaler` to keep the previous behaviour more conservatively.
    
    ```scala
    implicit val defaultSignaler: Signaler = ThreadSignaler
    ```
    
    I just double checked this passes the pending tests.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81494/testReport)** for PR 19150 at commit [`678d1b2`](https://github.com/apache/spark/commit/678d1b214f2d8cec72b47782177e406cbab9f5ee).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81501/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81500/testReport)** for PR 19150 at commit [`678d1b2`](https://github.com/apache/spark/commit/678d1b214f2d8cec72b47782177e406cbab9f5ee).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81500/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Thank you for review and approval!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Looks good. Yeah I didn't update everything when I did the scalatest update for 2.12 because the patch was so big already. Yes I also met the same Thread Signaler issue. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81494/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81485/testReport)** for PR 19150 at commit [`ab339b3`](https://github.com/apache/spark/commit/ab339b31b311035ebb75e8f079000d306cab16b8).
     * This patch **fails from timeout after a configured wait of \`250m\`**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class DriverSuite extends SparkFunSuite with TimeLimits `
      * `class AsyncRDDActionsSuite extends SparkFunSuite with BeforeAndAfterAll with TimeLimits `
      * `class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLimits `
      * `class EventLoopSuite extends SparkFunSuite with TimeLimits `
      * `trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with BeforeAndAfterAll `


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Thank  you, @jerryshao . I'll fix the typo.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81501/testReport)** for PR 19150 at commit [`678d1b2`](https://github.com/apache/spark/commit/678d1b214f2d8cec72b47782177e406cbab9f5ee).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81485/testReport)** for PR 19150 at commit [`ab339b3`](https://github.com/apache/spark/commit/ab339b31b311035ebb75e8f079000d306cab16b8).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19150: [SPARK-21939][TEST] Use TimeLimits instead of Tim...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19150


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81485/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    `BlockGeneratorSuite` and `StreamTest` is fixed and tested.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    **[Test build #81500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81500/testReport)** for PR 19150 at commit [`678d1b2`](https://github.com/apache/spark/commit/678d1b214f2d8cec72b47782177e406cbab9f5ee).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19150: [SPARK-21939][TEST] Use TimeLimits instead of Timeouts

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19150
  
    Thank you for review and merging, @jerryshao ! Also, thank you for review and approving, @HyukjinKwon and @srowen .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org