You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/13 16:25:17 UTC
[GitHub] [rocketmq-client-go] NeonToo opened a new pull request, #944: init crCh after topic with namespace instead of before which will cau…
NeonToo opened a new pull request, #944:
URL: https://github.com/apache/rocketmq-client-go/pull/944
…se consumption blocked; opt on log
## What is the purpose of the change
- the consumption blocked unexpectly since the crCh map key is without topic namespace
- more log info for some cases
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] NeonToo commented on pull request #944: init crCh after topic with namespace instead of before which will cau…
Posted by GitBox <gi...@apache.org>.
NeonToo commented on PR #944:
URL: https://github.com/apache/rocketmq-client-go/pull/944#issuecomment-1278399944
> #933 #934 It should be the same problem.Retry topic also needs to be considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #944: init crCh after topic with namespace instead of before which will cau…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #944:
URL: https://github.com/apache/rocketmq-client-go/pull/944#issuecomment-1278403171
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/944?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#944](https://codecov.io/gh/apache/rocketmq-client-go/pull/944?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (003b83f) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/8011561fc0018ee23dcd752814021df1bb2c7940?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8011561) will **increase** coverage by `0.04%`.
> The diff coverage is `46.66%`.
```diff
@@ Coverage Diff @@
## master #944 +/- ##
==========================================
+ Coverage 23.61% 23.65% +0.04%
==========================================
Files 52 52
Lines 7170 7179 +9
==========================================
+ Hits 1693 1698 +5
- Misses 5247 5251 +4
Partials 230 230
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/944/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `17.61% <0.00%> (ø)` | |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/944/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.17% <0.00%> (-0.01%)` | :arrow_down: |
| [internal/constants.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/944/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY29uc3RhbnRzLmdv) | `0.00% <0.00%> (ø)` | |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/944/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.29% <100.00%> (+0.48%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #944: [ISSUE #945]init crCh after topic with namespace to avoid consumption blocked.
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #944:
URL: https://github.com/apache/rocketmq-client-go/pull/944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] NeonToo closed pull request #944: init crCh after topic with namespace instead of before which will cau…
Posted by GitBox <gi...@apache.org>.
NeonToo closed pull request #944: init crCh after topic with namespace instead of before which will cau…
URL: https://github.com/apache/rocketmq-client-go/pull/944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] 0daypwn commented on pull request #944: init crCh after topic with namespace instead of before which will cau…
Posted by GitBox <gi...@apache.org>.
0daypwn commented on PR #944:
URL: https://github.com/apache/rocketmq-client-go/pull/944#issuecomment-1278366170
#933 #934
It should be the same problem.Retry topic also needs to be considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] hxzqlh commented on pull request #944: [ISSUE #945]init crCh after topic with namespace to avoid consumption blocked.
Posted by GitBox <gi...@apache.org>.
hxzqlh commented on PR #944:
URL: https://github.com/apache/rocketmq-client-go/pull/944#issuecomment-1278818883
I use the commit: [f3349bd](https://github.com/apache/rocketmq-client-go/commit/f3349bdbb4dbcf9a7481563cb0fc3dd3d3ce3985) which says it fix the push consuner blocked issued. While after my experience, it's also blocked while rocket mq actually has newest msg produced.
some log like this:
```
time="2022-10-14T10:19:19Z" level=warning msg="the queue's messages span too long, so do flow control" ConsumeConcurrentlyMaxSpan=1000 PullRequest="[ConsumerGroup: spot_quote_kline, Topic: etp_quotation, MessageQueue: brokerName=rocketmq-internal-0, queueId=0, nextOffset=18219201]" flowControlTimes=1 maxOffset=18219200 maxSpan=1404 minOffset=18217796
time="2022-10-14T10:19:21Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=1]" consumerGroup=spot_quote_kline offset=18117134
time="2022-10-14T10:19:21Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=2]" consumerGroup=spot_quote_kline offset=18218244
time="2022-10-14T10:19:21Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=3]" consumerGroup=spot_quote_kline offset=18217609
time="2022-10-14T10:19:21Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=%RETRY%spot_quote_kline, brokerName=rocketmq-internal-0, queueId=0]" consumerGroup=spot_quote_kline offset=668
time="2022-10-14T10:19:21Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=0]" consumerGroup=spot_quote_kline offset=18217796
time="2022-10-14T10:19:26Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=0]" consumerGroup=spot_quote_kline offset=18217796
time="2022-10-14T10:19:26Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=1]" consumerGroup=spot_quote_kline offset=18117134
time="2022-10-14T10:19:26Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=2]" consumerGroup=spot_quote_kline offset=18218244
time="2022-10-14T10:19:26Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=3]" consumerGroup=spot_quote_kline offset=18217609
time="2022-10-14T10:19:26Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=%RETRY%spot_quote_kline, brokerName=rocketmq-internal-0, queueId=0]" consumerGroup=spot_quote_kline offset=668
time="2022-10-14T10:19:31Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=0]" consumerGroup=spot_quote_kline offset=18217796
time="2022-10-14T10:19:31Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=1]" consumerGroup=spot_quote_kline offset=18117134
time="2022-10-14T10:19:31Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=2]" consumerGroup=spot_quote_kline offset=18218244
time="2022-10-14T10:19:31Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=etp_quotation, brokerName=rocketmq-internal-0, queueId=3]" consumerGroup=spot_quote_kline offset=18217609
time="2022-10-14T10:19:31Z" level=info msg="update offset to broker success" MessageQueue="MessageQueue [topic=%RETRY%spot_quote_kline, brokerName=rocketmq-internal-0, queueId=0]" consumerGroup=spot_quote_kline offset=668
time="2022-10-14T10:19:31Z" level=warning msg="the queue's messages span too long, so do flow control" ConsumeConcurrentlyMaxSpan=1000 PullRequest="[ConsumerGroup: spot_quote_kline, Topic: etp_quotation, MessageQueue: brokerName=rocketmq-internal-0, queueId=3, nextOffset=18218971]" flowControlTimes=1 maxOffset=18218970 maxSpan=1361 minOffset=18217609
```
then, after some minutes, the client continue consumed out new msg.
For shor, the client do the loop: consumed some msg ---> blocked for a period of time ----> continue consumed out msg ----> blocked for a period of time ---> continue consumed out msg.
PS: rocket mq always has new msg produced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org